ci: Show flavour in about this app and sentry #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📈 Analytics
Codecov Report
@@ Coverage Diff @@
## develop #3429 +/- ##
===========================================
- Coverage 11.30% 11.30% -0.01%
===========================================
Files 260 260
Lines 12555 12557 +2
===========================================
Hits 1419 1419
- Misses 11136 11138 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Something we didn't need until know. But we will certainly need it in the future #3427
Now we show the app flavour in the "about this app" section as well as sending it to sentry.
Why a global variable?
The value won't change after the build and I put it in the main.dart because I didn't know where else to put. A single dedicated file seems again too much. If we later find anything to pair it with why not?